Fix for regression in open_succeeds_twice and minimal_writer_example tests
#1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Orlov <[email protected]>
- The `serialized_msg2` is not owning the serialized data after the first call writer.write(serialized_msg2,..). i.e. need to use another message or another API in test for second call to writer.write(msg). Signed-off-by: Michael Orlov <[email protected]>
MichaelOrlov
requested review from
gbiggs and
james-rms
and removed request for
a team
MichaelOrlov
requested review from
clalancette and
claraberendsen
and removed request for
gbiggs and
james-rms
clalancette
approved these changes
May 21, 2024
|
Pulls: #1667
|
delete-merged-branch
bot
deleted the
morlov/fix_for_ci_regression_on_rolling
branch
|
https://github.com/Mergifyio backport iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 21, 2024
…le` tests (#1667) * Use test-specific temp subfolder to avoid leftovers from previous run Signed-off-by: Michael Orlov <[email protected]> * Address flakiness in TestRosbag2CPPAPI::minimal_writer_example - The `serialized_msg2` is not owning the serialized data after the first call writer.write(serialized_msg2,..). i.e. need to use another message or another API in test for second call to writer.write(msg). Signed-off-by: Michael Orlov <[email protected]> --------- Signed-off-by: Michael Orlov <[email protected]> (cherry picked from commit 8523995) # Conflicts: # rosbag2_compression/test/rosbag2_compression/test_sequential_compression_writer.cpp
|
Pulls: #1667
|
MichaelOrlov
added a commit
that referenced
this pull request
May 22, 2024
…r_example` tests (backport #1667) (#1669) * Fix for "open_succeeds_twice" test failure on second run - Use std::filesystem for temp files and folders operation. For some reason rcpputils::fs::delete_all(folder_name) wasn't able to delete temp folder with subfolders. Signed-off-by: Michael Orlov <[email protected]> * Address flakiness in TestRosbag2CPPAPI::minimal_writer_example - The `serialized_msg2` is not owning the serialized data after the first call writer.write(serialized_msg2,..). i.e. need to use another message or another API in test for second call to writer.write(msg). Signed-off-by: Michael Orlov <[email protected]> --------- Signed-off-by: Michael Orlov <[email protected]> Co-authored-by: Michael Orlov <[email protected]>
|
https://github.com/Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 23, 2024
…le` tests (#1667) * Use test-specific temp subfolder to avoid leftovers from previous run Signed-off-by: Michael Orlov <[email protected]> * Address flakiness in TestRosbag2CPPAPI::minimal_writer_example - The `serialized_msg2` is not owning the serialized data after the first call writer.write(serialized_msg2,..). i.e. need to use another message or another API in test for second call to writer.write(msg). Signed-off-by: Michael Orlov <[email protected]> --------- Signed-off-by: Michael Orlov <[email protected]> (cherry picked from commit 8523995)
MichaelOrlov
added a commit
that referenced
this pull request
May 24, 2024
…le` tests (#1667) (#1675) * Use test-specific temp subfolder to avoid leftovers from previous run Signed-off-by: Michael Orlov <[email protected]> * Address flakiness in TestRosbag2CPPAPI::minimal_writer_example - The `serialized_msg2` is not owning the serialized data after the first call writer.write(serialized_msg2,..). i.e. need to use another message or another API in test for second call to writer.write(msg). Signed-off-by: Michael Orlov <[email protected]> --------- Signed-off-by: Michael Orlov <[email protected]> (cherry picked from commit 8523995) Co-authored-by: Michael Orlov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message from CI reference build:
rosbag2_compression.SequentialCompressionWriterTest.open_succeeds_twiceon a second run due to the leftovers in the temp folder.It also addresses the flakiness in
TestRosbag2CPPAPI::minimal_writer_exampledue to using shared ptr to the serialized message twice in thewriter.write(msg)call.Note. The "serialized_msg2" in the
TestRosbag2CPPAPI::minimal_writer_exampledoes not own the serialized data after the first call writer.write(serialized_msg2,..). i.e. need to use another message or another API in the test for the second call to the writer.write(msg).