Upstream quality changes from Apex.AI part 1

[MichaelOrlov]

This PR consolidates fixes related to the code quality and stability after backporting Rosbag2 PRs to Apex.AI. PART 1

List of changes:

1. Fix for memory leaks in tests
   Details: Need to use custom deleter when releasing rcl serialized buffer to a shared pointer.
2. Move wait_for_playback_to_start() to public section
   • Rationale: Need to use in another package
   • Also added timeout parameter for the wait_for_playback_to_start(..) to make it non-blocking call optionally and return boolean value.
3. Gracefully handle exceptions from on-play callbacks in player
   Rationale: Avoid abnormal termination in case of unhandled exceptions happening in callbacks.
4. Address Axivion warnings in rosbag2_py
   Description:
   1. MisraC++2023-8.1.1 [required]: _transport.cpp:286 This variable shall not be implicitly captured in a lambda expression.; Field: []
   2. MisraC++2023-8.2.3 [required]: _transport.cpp:50 Cast removes const qualification; Field: [const char*->char*]
5. Fix the clang16 warning that the timestamp comparator is not initialized
6. Make sure to start with a clean subscriptions list in Recorder::record()
   Rationale: It could be some residual subscriptions in the list in case if the previous call to Recorder::record() failed for some reason and Recorder::stop() wasn't called.
7. Call discovery_future_.get() if it's ready in the stop_discovery()
8. Use absolute path instead of relative path in the InfoEndToEndTestFixture
9. Don't keep trying to publish the next message if we fail the first time. The Player::play_next() should return false right away if, for some reason, failed to publish the current message.

[MichaelOrlov]

There are a few failures on CI that need to be addressed. Turning this PR back to draft.
Sorry it was premature to ask for review.

[MichaelOrlov]

Ok. Now the CI is green and this PR is ready for review.

[christophebedard]

Minor changes.

[christophebedard]

Also, you don't really need to mention/frame the title of this PR as a "sync with Apex.AI"

[MichaelOrlov]

@christophebedard Could you please give a one more round of review?
I've addressed review comments and also added a few more fixes

7. Call discovery_future_.get() if it's ready in the stop_discovery()
8. Use absolute path instead of relative path in the InfoEndToEndTestFixture
9. Don't keep trying to publish the next message if we fail the first time. The Player::play_next() should return false right away if, for some reason, failed to publish the current message.

[christophebedard]

If you really want to proceed as-is with the wait_for_playback_to_start() docs, this looks good to me with green CI.

[MichaelOrlov]

Pulls: #1903
Gist: https://gist.githubusercontent.com/MichaelOrlov/09606b1727cd650b8ad81063eca5060f/raw/2aab4e80b4711be3bfd625549652c96db827c46d/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_transport rosbag2_py rosbag2_storage_mcap rosbag2_test_common rosbag2_tests
TEST args: --packages-above rosbag2_transport rosbag2_py rosbag2_storage_mcap rosbag2_test_common rosbag2_tests
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15128

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[MichaelOrlov]

@christophebedard Thank you for review.

[MichaelOrlov]

https://github.com/Mergifyio backport jazzy

[mergify]

backport jazzy

✅ Backports have been created

• #1909 Upstream quality changes from Apex.AI part 1 (backport #1903) has been created for branch jazzy but encountered conflicts