Fix build issues when rosbag2_storage is binary installed #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several packages were failing to build from source when rosbag2_storage was installed from a binary package because the path to the binary install was being added to CMake's include path before the workspace path. This tweaks the dependencies and include orders to ensure the source workspace path is preferred. Fixes ros2#583 Distro A, OPSEC #4584 Signed-off-by: P. J. Reed <[email protected]>
This was referenced Jan 28, 2021
emersonknapp
approved these changes
Jan 28, 2021
pjreed
requested review from
thomas-moulard and
zmichaels11
and removed request for
a team
zmichaels11
approved these changes
Jan 28, 2021
|
Gist: https://gist.githubusercontent.com/emersonknapp/c78911c644a268d15405ea377138d831/raw/cc8049975ebc06535e58adfd6911b3161642b4e5/ros2.repos
|
emersonknapp
pushed a commit
that referenced
this pull request
Feb 2, 2021
Several packages were failing to build from source when rosbag2_storage was installed from a binary package because the path to the binary install was being added to CMake's include path before the workspace path. This tweaks the dependencies and include orders to ensure the source workspace path is preferred. Fixes #583 Distro A, OPSEC #4584 Signed-off-by: P. J. Reed <[email protected]>
emersonknapp
pushed a commit
that referenced
this pull request
Feb 17, 2021
Several packages were failing to build from source when rosbag2_storage was installed from a binary package because the path to the binary install was being added to CMake's include path before the workspace path. This tweaks the dependencies and include orders to ensure the source workspace path is preferred. Fixes #583 Distro A, OPSEC #4584 Signed-off-by: P. J. Reed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several packages were failing to build from source when rosbag2_storage
was installed from a binary package because the path to the binary
install was being added to CMake's include path before the workspace
path. This tweaks the dependencies and include orders to ensure the
source workspace path is preferred.
Fixes #583
Distro A, OPSEC #4584
Signed-off-by: P. J. Reed [email protected]