Fixed playing if unknown message types exist #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. play a specific known message type even if some unknown types exist. 2. add a warning message while a message type library not exist. Signed-off-by: Chen Lihui <[email protected]>
iuhilnehc-ynos
requested review from
emersonknapp and
dabonnie
and removed request for
a team
emersonknapp
approved these changes
Dec 29, 2020
| @@ -44,7 +44,7 @@ class MockSequentialReader : public rosbag2_cpp::reader_interfaces::BaseReaderIn | |||
|
|
|||
| while (num_read_ < messages_.size()) { | |||
| for (const auto & filter_topic : filter_.topics) { | |||
| if (!messages_[num_read_ + 1]->topic_name.compare(filter_topic)) { | |||
| if (!messages_[num_read_]->topic_name.compare(filter_topic)) { | |||
There was a problem hiding this comment.
Is this change actually necessary?
| topic.name, rosbag2_transport_->create_generic_publisher( | ||
| topic.name, topic.type, topic_qos))); | ||
| } catch (const std::runtime_error & e) { | ||
| // using a warning log seems better than adding a new option |
There was a problem hiding this comment.
This comment doesn't make much sense without the context of the issue conversation - i think that the text in the warning explains it well enough.
|
Gist: https://gist.githubusercontent.com/emersonknapp/14502914c97ff87953246acb31fd7622/raw/5a1b1739bf80b50809975253103a1e68a56ef542/ros2.repos
|
|
The windows build: Considering the action CI here ran the linters, let's not be blocked on that. |
adamdbrw
pushed a commit
that referenced
this pull request
Jan 14, 2021
1. play a specific known message type even if some unknown types exist. 2. add a warning message while a message type library not exist. Signed-off-by: Chen Lihui <[email protected]>
emersonknapp
pushed a commit
that referenced
this pull request
Feb 2, 2021
1. play a specific known message type even if some unknown types exist. 2. add a warning message while a message type library not exist. Signed-off-by: Chen Lihui <[email protected]>
emersonknapp
pushed a commit
that referenced
this pull request
Feb 17, 2021
1. play a specific known message type even if some unknown types exist. 2. add a warning message while a message type library not exist. Signed-off-by: Chen Lihui <[email protected]>
|
@emersonknapp I believe we should backport this to Foxy. |
emersonknapp
pushed a commit
that referenced
this pull request
Mar 19, 2021
1. play a specific known message type even if some unknown types exist. 2. add a warning message while a message type library not exist. Signed-off-by: Chen Lihui <[email protected]>
emersonknapp
pushed a commit
that referenced
this pull request
Mar 19, 2021
1. play a specific known message type even if some unknown types exist. 2. add a warning message while a message type library not exist. Signed-off-by: Chen Lihui <[email protected]> Signed-off-by: Emerson Knapp <[email protected]>
1 task
emersonknapp
pushed a commit
that referenced
this pull request
Jul 9, 2021
1. play a specific known message type even if some unknown types exist. 2. add a warning message while a message type library not exist. Signed-off-by: Chen Lihui <[email protected]>
emersonknapp
pushed a commit
that referenced
this pull request
Jul 10, 2021
1. play a specific known message type even if some unknown types exist. 2. add a warning message while a message type library not exist. Signed-off-by: Chen Lihui <[email protected]>
emersonknapp
added a commit
that referenced
this pull request
Jul 15, 2021
#592) (#686) 1. play a specific known message type even if some unknown types exist. 2. add a warning message while a message type library not exist. Signed-off-by: Chen Lihui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #591
Signed-off-by: Chen Lihui [email protected]