Fix relative metadata paths in SequentialCompressionWriter #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersonknapp
requested review from
zmichaels11 and
prajakta-gokhale
and removed request for
a team
emersonknapp
force-pushed
the
emersonknapp/compression-writer-correct-relative-paths
branch
from
5504e9a to
aa0dbf1
Compare
zmichaels11
approved these changes
Jan 25, 2021
rosbag2_compression/src/rosbag2_compression/sequential_compression_writer.cpp
Outdated
Show resolved
Hide resolved
rosbag2_compression/src/rosbag2_compression/sequential_compression_writer.cpp
Outdated
Show resolved
Hide resolved
emersonknapp
changed the title
prajakta-gokhale
approved these changes
Jan 25, 2021
emersonknapp
force-pushed
the
emersonknapp/compression-writer-correct-relative-paths
branch
from
247c48c to
03d26d5
Compare
|
Gist: https://gist.githubusercontent.com/emersonknapp/48d4065acf325d5ca483591e2588d687/raw/cc4ce0d6c338621125898050f630578454945852/ros2.repos
|
added 3 commits
January 26, 2021 17:05
…siness logic Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
emersonknapp
force-pushed
the
emersonknapp/compression-writer-correct-relative-paths
branch
from
c593177 to
bf9bd04
Compare
zmichaels11
approved these changes
Jan 27, 2021
rosbag2_compression/src/rosbag2_compression/sequential_compression_writer.cpp
Outdated
Show resolved
Hide resolved
… portability. Signed-off-by: Emerson Knapp <[email protected]>
emersonknapp
force-pushed
the
emersonknapp/compression-writer-correct-relative-paths
branch
4 times, most recently
from
5f39bbf to
c50ec86
Compare
…g run properly in the github test Signed-off-by: Emerson Knapp <[email protected]>
emersonknapp
force-pushed
the
emersonknapp/compression-writer-correct-relative-paths
branch
from
c50ec86 to
8506827
Compare
Signed-off-by: Emerson Knapp <[email protected]>
emersonknapp
force-pushed
the
emersonknapp/compression-writer-correct-relative-paths
branch
from
2f0406d to
9990110
Compare
|
delete-merged-branch
bot
deleted the
emersonknapp/compression-writer-correct-relative-paths
branch
emersonknapp
added a commit
that referenced
this pull request
Jan 28, 2021
…riter (#613) Signed-off-by: Emerson Knapp <[email protected]>
emersonknapp
added a commit
that referenced
this pull request
Feb 2, 2021
* Fix relative metadata path writing in compression by deduplicating business logic Signed-off-by: Emerson Knapp <[email protected]>
emersonknapp
added a commit
that referenced
this pull request
Feb 17, 2021
* Fix relative metadata path writing in compression by deduplicating business logic Signed-off-by: Emerson Knapp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #557
Related to #612
This makes the SequentialCompressionWriter write in the bag metadata with correct relative paths in the V4 format.