[backport foxy-future] Reindexer (#641, #699) #860
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new C++ Reindexer class for reconstructing metadata from bags that are missing it. Distro A, OPSEC #4584 Signed-off-by: Jacob Hassold <[email protected]> Signed-off-by: Emerson Knapp <[email protected]>
* CLI interface to the rosbag2_cpp Reindexer `ros2 bag reindex` Distro A, OPSEC #4584 Signed-off-by: Jacob Hassold <[email protected]>
emersonknapp
requested review from
Karsten1987 and
MichaelOrlov
and removed request for
a team
emersonknapp
force-pushed
the
emersonknapp/backport-foxy-future-reindexer
branch
2 times, most recently
from
dd5ce35 to
98ff023
Compare
|
Compatibility fixes in separate commit:
|
Signed-off-by: Emerson Knapp <[email protected]>
emersonknapp
force-pushed
the
emersonknapp/backport-foxy-future-reindexer
branch
from
98ff023 to
fb273e3
Compare
MichaelOrlov
reviewed
Sep 2, 2021
There was a problem hiding this comment.
While implementation looks god for me, I would recommend to move compatibility related code which is corresponds to the ros2/rcutils#323 to the separate files in the same rosbag2_cpp include and src folders.
The rational for that is that if someone in the future will try to backport ros2/rcutils#323 the code will not compile until removing this workaround. And it will not pollute reindexer.cpp
|
Is there some way to fix one last failed check? Looks like it is some kind of problem with signing-off commits |
|
That's not a blocking issue - more importantly it needs ci.ros2.org run on it |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PRs #641 (reindexer functionality) and #699 (reindexer CLI) to foxy-future branch.
Related to #859