Fix converter plugin choices for record #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n for record. 2 - fix naming for CLI choices due to _converter suffix logic Signed-off-by: Emerson Knapp <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
emersonknapp
requested review from
MichaelOrlov and
david-prody
and removed request for
a team
lihui815
approved these changes
Oct 28, 2021
|
Gist: https://gist.githubusercontent.com/emersonknapp/187792b61213edaec88e055455339e2a/raw/ac333442d64e73c16f9f6c281623b3fc7aa2ae53/ros2.repos
|
delete-merged-branch
bot
deleted the
emersonknapp/converter-plugin-choices
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"_converter"suffix logic, before you could not actually choose a plugin because the names would be misinterpreted at a lower level