Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change UUID type in action msgs #332

Merged
merged 5 commits into from
Dec 7, 2018
Merged

Change UUID type in action msgs #332

merged 5 commits into from
Dec 7, 2018

Conversation

apojomovsky
Copy link
Contributor

@apojomovsky apojomovsky commented Nov 21, 2018 •
edited by sloretz
Loading

This PR is part of a series of three that together close ros2/rcl_interfaces#49
EDIT: Depends on ros2/ros2#609

  • Update rcl_action to make use of uuid field in GoalInfo.msg
  • Make use of unique_identifier_msgs/uuid in parser.py
  • Fixe test_parse_action_string.py test

Connects to ros2/rcl_interfaces#49
blocked by #298
requires ros2/rcl_interfaces#54

@tfoote tfoote added the in progress Actively being worked on (Kanban column) label Nov 21, 2018
@dirk-thomas
Copy link
Member

Please only merge this patch until after the IDL PRs have landed since they refactor the touched code significantly.

hidmic
hidmic reviewed Nov 21, 2018
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sloretz sloretz mentioned this pull request Nov 27, 2018
Closed
24 tasks
sloretz
sloretz approved these changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI if the IDL PRs don't get merged in time.

This was referenced Dec 4, 2018
Merged
Merged
Merged
@sloretz sloretz added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Dec 6, 2018
@sloretz
Copy link
Contributor

sloretz commented Dec 6, 2018 •
edited
Loading

CI for this, ros2/rcl#353, ros2/rclcpp#602

  • Linux Build Status (Uncrustify rmw_fastrtps, unrelated to these PRs)
  • Linux-aarch64 Build Status (Uncrustify rmw_fastrtps, unrelated to these PRs)
  • macOS Build Status (Uncrustify rmw_fastrtps, unrelated to these PRs)
  • Windows Build Status (Uncrustify rmw_fastrtps, unrelated to these PRs)

@sloretz sloretz added this to the crystal milestone Dec 6, 2018
@sloretz
Copy link
Contributor

sloretz commented Dec 6, 2018 •
edited
Loading

CI again after fixing conflicts in rcl pr

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz merged commit 3c1d4fc into master Dec 7, 2018
@sloretz sloretz deleted the apojomovsky/change_uuid_type_in_action_msgs branch December 7, 2018 00:42
@sloretz sloretz removed the in review Waiting for review (Kanban column) label Dec 7, 2018
@sloretz sloretz mentioned this pull request Dec 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic left review comments

@sloretz sloretz sloretz approved these changes

@jacobperron jacobperron Awaiting requested review from jacobperron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
crystal
Development

Successfully merging this pull request may close these issues.

Change UUID type in action_msgs
5 participants
@apojomovsky @dirk-thomas @sloretz @hidmic @tfoote