-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename rosidl_generator_cpp namespace to rosidl_runtime_cpp #456
Conversation
Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]>
I accidentally squash merged the PR. Since the intention was to keep the two commits separate (to maintain history) I force pushed to |
I just updated my workspace with
am I missing something here? I tried compiling with |
You might want to check that you have the latest master of this repo as well as all the referenced PRs. If you use a branch on any of them you will likely need to rebase it. |
The build is currently failing on a fresh checkout of master from this PR - https://ci.ros2.org/view/All/job/ci_linux/10100/console Edit 1 for context: Built up to Edit 2: but i don't fully understand why this change would cause the breakage, it doesn't seem to have touched |
I don't fully grasp the dependencies here:
|
Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]>
This was the actual problem - I was already working on the follow up patch to move the I have fixed the problem with the two recently referenced commits which only touch Sorry for the hassle (it didn't help that I went for a bike ride after force push...). |
The headers have been moved in #442 but the directory / namespace has not been updated. This PR does exactly that - update the namespace to match the package name - for the C++ generator / runtime. A similar PR for C will need to follow. All part of the API review in #446 / #447. |
Follow up of #442 as part of #447 to match namespace with the package the name the symbols are defined in.