New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of ament_target_dependencies #222

Merged

sloretz merged 1 commit into rolling from sloretz__rosidl_python_remove_atd

Feb 16, 2025

Contributor

sloretz commented Feb 14, 2025

ament/ament_cmake#292

This removes a use of ament_target_dependencies() in rosidl_generator_py and replaces it with ... nothing!

rosidl_generator_py doesn't export any CMake targets or old-style standard cmake variables, so this call had no effect.


          Remove use of ament_target_dependencies

d29c65f

Signed-off-by: Shane Loretz <[email protected]>

ahcorde approved these changes

View reviewed changes

Contributor

ahcorde commented Feb 14, 2025

Pulls: #222
Gist: https://gist.githubusercontent.com/ahcorde/f9cd3f9ca722729358670804e2540762/raw/10c138da996f2e8c405c4b15c3c0bce1f6364261/ros2.repos
BUILD args: --packages-above-and-dependencies rosidl_generator_py
TEST args: --packages-above rosidl_generator_py
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15197

Linux
Linux-aarch64
Linux-rhel
Windows

sloretz merged commit 1d4a4c7 into rolling

3 checks passed

sloretz deleted the sloretz__rosidl_python_remove_atd branch

February 16, 2025 19:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet