Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade benign error messages to debug #107

Closed
wants to merge 2 commits into from
Closed

Downgrade benign error messages to debug #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1194e73
Downgrade benign error messages to debug
asorbini Apr 1, 2021
52e5898
Add missing logging macros header
asorbini Apr 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions rosidl_typesupport_c/src/type_support_dispatch.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#include "rcpputils/shared_library.hpp"
#include "rcutils/error_handling.h"
#include "rcutils/snprintf.h"
#include "rcutils/logging_macros.h"
#include "rosidl_typesupport_c/identifier.h"
#include "rosidl_typesupport_c/type_support_map.h"

Expand Down Expand Up @@ -110,9 +111,12 @@ get_typesupport_handle_function(
return ts;
}
}
RCUTILS_SET_ERROR_MSG_WITH_FORMAT_STRING(
"Handle's typesupport identifier (%s) is not supported by this library",

RCUTILS_LOG_DEBUG_NAMED(
"rosidl_typesupport_c",
"type support `%s` is not used by this library",
handle->typesupport_identifier);

return nullptr;
}

Expand Down
8 changes: 6 additions & 2 deletions rosidl_typesupport_cpp/src/type_support_dispatch.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#include "rcpputils/shared_library.hpp"
#include "rcutils/error_handling.h"
#include "rcutils/snprintf.h"
#include "rcutils/logging_macros.h"
#include "rosidl_typesupport_c/type_support_map.h"

namespace rosidl_typesupport_cpp
Expand Down Expand Up @@ -108,9 +109,12 @@ get_typesupport_handle_function(
return ts;
}
}
RCUTILS_SET_ERROR_MSG_WITH_FORMAT_STRING(
"Handle's typesupport identifier (%s) is not supported by this library",

RCUTILS_LOG_DEBUG_NAMED(
"rosidl_typesupport_cpp",
"type support `%s` is not used by this library",
handle->typesupport_identifier);

return nullptr;
}

Expand Down