This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Changes to support preallocate #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
reviewed
Feb 6, 2019
| @@ -348,6 +362,10 @@ to_cdr_stream( | |||
| fprintf(stderr, "failed to call @(spec.base_type.type)_Plugin_serialize_to_cdr_buffer()\n"); | |||
| return false; | |||
| } | |||
|
|
|||
|
|
|||
| printf("EXPECTED LENGTH INTO TO_CDR_STREAM : %u\n", expected_length); | |||
| @@ -322,6 +322,20 @@ else: | |||
| return true; | |||
| } | |||
|
|
|||
| static bool get_serialized_length(unsigned int * expected_length) | |||
There was a problem hiding this comment.
I know the other functions are structured this way, but I think we should start to move towards the ability to set and report error states. So instead of returning a bool, I think it would be better to return an rmw_ret_t and instead of printing to stderr with fprintf, I'd like to see us using the error state with RMW_SET_ERROR_MSG.
We don't need to refactor all of the generated code here to be the same, but in this instance I'd slightly prefer a trend toward better error reporting over consistency with the rest of the existing file.
gonzodepedro
added
in review
added 5 commits
May 3, 2019 11:00
Signed-off-by: Gonzalo de Pedro <[email protected]>
Signed-off-by: Gonzalo de Pedro <[email protected]>
Signed-off-by: Gonzalo de Pedro <[email protected]>
Signed-off-by: Gonzalo de Pedro <[email protected]>
Signed-off-by: Gonzalo de Pedro <[email protected]>
gonzodepedro
force-pushed
the
gonzodepedro/rmw_preallocate
branch
from
a6e307c to
84c4fb1
Compare
|
I think we should close this @gonzodepedro. Thoughts? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In progress work to support rmw_preallocate.
Connects to ros2/rmw_connext#345
Signed-off-by: Gonzalo de Pedro [email protected]