This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
add WString support #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
added
enhancement
jacobperron
reviewed
May 1, 2019
| @@ -344,7 +365,10 @@ if isinstance(type_, AbstractNestedType): | |||
| return false; | |||
| } | |||
| @[ elif isinstance(type_, AbstractWString)]@ | |||
| @{ assert False, 'TBD'}@ | |||
| if (!ros_i.data) { | |||
| rosidl_generator_c__U16String__init(&ros_i); | |||
There was a problem hiding this comment.
We should probably guard against the unlikely case that this call fails (same below). I noticed that the same could be done for regular strings.
There was a problem hiding this comment.
Since the same is true for strings I would rather not do it right now. Maybe we can delay this to a follow up PR?
jacobperron
approved these changes
May 1, 2019
Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]>
jacobperron
approved these changes
May 2, 2019
Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]>
jacobperron
approved these changes
May 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect to ros2/rosidl#352.
While waiting for ros2/rcl_interfaces#58 the patch (without tests) can already be reviewed.