When a URDF link has multiple visual tags, use appropriate material for each #1329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when loading a URDF robot, rviz uses the same material for each link, even when the link has multiple
<visual>
tags with different materials. See #1293 (comment) for a detailed analysis.Fixes #1293.
I tested that this fixes my use case on ROS Iron (display of a robot inside MoveIt plugin), but do not know enough to test more broadly. The code change appears to apply cleanly to rolling, but I have not tested outside of Iron either. Leaving it to maintainer to figure out the right branch(es) to merge this into.