Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug preventing generate_policy verb from working with publishers and services #91

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Fix bug preventing generate_policy verb from working with publishers and services #91

merged 1 commit into from
Mar 5, 2019

Conversation

jacobperron
Copy link
Member

Resolves #89

@jacobperron jacobperron added the in progress Actively being worked on (Kanban column) label Mar 4, 2019
@jacobperron jacobperron mentioned this pull request Mar 4, 2019
Closed
@jacobperron jacobperron added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Mar 4, 2019
@jacobperron
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

ruffsl
ruffsl approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@ruffsl ruffsl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bugfix solves the relative missing permissions described in #89 . Although, there doesn't seem a way for rosgraph API to return the service names a node would need request access for. I.e. current node in crystal require some overzealous permissions for request access to local parameter services hosted. This may be a separate issue.

@jacobperron
Copy link
Member Author

Although, there doesn't seem a way for rosgraph API to return the service names a node would need request access for. I.e. current node in crystal require some overzealous permissions for request access to local parameter services hosted. This may be a separate issue.

Sounds like a separate issue; feel free to open a ticket.

@jacobperron jacobperron merged commit f1f9e24 into master Mar 5, 2019
@jacobperron jacobperron deleted the jacob/fix_89 branch March 5, 2019 03:08
@jacobperron jacobperron removed the in review Waiting for review (Kanban column) label Mar 5, 2019
@ruffsl ruffsl mentioned this pull request Mar 8, 2019
Closed
@mjcarroll mjcarroll mentioned this pull request Mar 11, 2019
Merged
@nuclearsandwich nuclearsandwich mentioned this pull request Mar 13, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruffsl ruffsl ruffsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobperron @ruffsl