feat: use gold for find match results

Closes #58 - VSCode added editor.findMatchForeground upstream, enabling better customization of find match colors. Used gold instead of rose for search matches as rose is already used throughout UI. This is an opinionated change; open to feedback.
rose-pine · Oct 8, 2024 · 55b3b9c · 55b3b9c
1 parent dc05e34
commit 55b3b9c
Show file tree

Hide file tree

Showing 8 changed files with 33 additions and 16 deletions.
diff --git a/pinecone.config.js b/pinecone.config.js
@@ -18,6 +18,11 @@ Object.keys(roles).map((role) => {
 		moon: colorish(currentRole.moon.hex, 0.5),
 		dawn: colorish(currentRole.dawn.hex, 0.5),
 	}
+	palette[`${role}/30`] = {
+		main: colorish(currentRole.main.hex, 0.3),
+		moon: colorish(currentRole.moon.hex, 0.3),
+		dawn: colorish(currentRole.dawn.hex, 0.3),
+	}
 	palette[`${role}/15`] = {
 		main: colorish(currentRole.main.hex, 0.15),
 		moon: colorish(currentRole.moon.hex, 0.15),

diff --git a/themes/_pinecone-color-theme.json b/themes/_pinecone-color-theme.json
@@ -91,9 +91,11 @@
 		"dropdown.foreground": "$text",
 		"dropdown.listBackground": "$surface",
 		"editor.background": "$base",
-		"editor.findMatchBackground": "$highlightHigh",
+		"editor.findMatchBackground": "$gold",
 		"editor.findMatchBorder": "",
-		"editor.findMatchHighlightBackground": "$highlightHigh",
+		"editor.findMatchForeground": "$text",
+		"editor.findMatchHighlightBackground": "$gold/30",
+		"editor.findMatchHighlightForeground": "$base",
 		"editor.findMatchHighlightBorder": "",
 		"editor.findRangeHighlightBackground": "$highlightHigh",
 		"editor.findRangeHighlightBorder": "$transparent",
@@ -640,8 +642,6 @@
 		"diffEditorGutter.insertedLineBackground": "",
 		"diffEditorGutter.removedLineBackground": "",
 		"disabledForeground": "",
-		"editor.findMatchForeground": "",
-		"editor.findMatchHighlightForeground": "",
 		"editor.foldPlaceholderForeground": "",
 		"editor.placeholder.foreground": "",
 		"editor.wordHighlightTextBackground": "",

diff --git a/themes/rose-pine-color-theme.json b/themes/rose-pine-color-theme.json
@@ -69,8 +69,10 @@
 		"dropdown.foreground": "#e0def4",
 		"dropdown.listBackground": "#1f1d2e",
 		"editor.background": "#191724",
-		"editor.findMatchBackground": "#6e6a8666",
-		"editor.findMatchHighlightBackground": "#6e6a8666",
+		"editor.findMatchBackground": "#f6c177",
+		"editor.findMatchForeground": "#e0def4",
+		"editor.findMatchHighlightBackground": "#f6c1774d",
+		"editor.findMatchHighlightForeground": "#191724",
 		"editor.findRangeHighlightBackground": "#6e6a8666",
 		"editor.findRangeHighlightBorder": "#0000",
 		"editor.focusedStackFrameHighlightBackground": "#6e6a8633",

diff --git a/themes/rose-pine-dawn-color-theme.json b/themes/rose-pine-dawn-color-theme.json
@@ -69,8 +69,10 @@
 		"dropdown.foreground": "#575279",
 		"dropdown.listBackground": "#fffaf3",
 		"editor.background": "#faf4ed",
-		"editor.findMatchBackground": "#6e6a8626",
-		"editor.findMatchHighlightBackground": "#6e6a8626",
+		"editor.findMatchBackground": "#ea9d34",
+		"editor.findMatchForeground": "#575279",
+		"editor.findMatchHighlightBackground": "#ea9d344d",
+		"editor.findMatchHighlightForeground": "#faf4ed",
 		"editor.findRangeHighlightBackground": "#6e6a8626",
 		"editor.findRangeHighlightBorder": "#0000",
 		"editor.focusedStackFrameHighlightBackground": "#6e6a8614",

diff --git a/themes/rose-pine-dawn-no-italics-color-theme.json b/themes/rose-pine-dawn-no-italics-color-theme.json
@@ -69,8 +69,10 @@
 		"dropdown.foreground": "#575279",
 		"dropdown.listBackground": "#fffaf3",
 		"editor.background": "#faf4ed",
-		"editor.findMatchBackground": "#6e6a8626",
-		"editor.findMatchHighlightBackground": "#6e6a8626",
+		"editor.findMatchBackground": "#ea9d34",
+		"editor.findMatchForeground": "#575279",
+		"editor.findMatchHighlightBackground": "#ea9d344d",
+		"editor.findMatchHighlightForeground": "#faf4ed",
 		"editor.findRangeHighlightBackground": "#6e6a8626",
 		"editor.findRangeHighlightBorder": "#0000",
 		"editor.focusedStackFrameHighlightBackground": "#6e6a8614",

diff --git a/themes/rose-pine-moon-color-theme.json b/themes/rose-pine-moon-color-theme.json
@@ -69,8 +69,10 @@
 		"dropdown.foreground": "#e0def4",
 		"dropdown.listBackground": "#2a273f",
 		"editor.background": "#232136",
-		"editor.findMatchBackground": "#817c9c4d",
-		"editor.findMatchHighlightBackground": "#817c9c4d",
+		"editor.findMatchBackground": "#f6c177",
+		"editor.findMatchForeground": "#e0def4",
+		"editor.findMatchHighlightBackground": "#f6c1774d",
+		"editor.findMatchHighlightForeground": "#232136",
 		"editor.findRangeHighlightBackground": "#817c9c4d",
 		"editor.findRangeHighlightBorder": "#0000",
 		"editor.focusedStackFrameHighlightBackground": "#817c9c26",

diff --git a/themes/rose-pine-moon-no-italics-color-theme.json b/themes/rose-pine-moon-no-italics-color-theme.json
@@ -69,8 +69,10 @@
 		"dropdown.foreground": "#e0def4",
 		"dropdown.listBackground": "#2a273f",
 		"editor.background": "#232136",
-		"editor.findMatchBackground": "#817c9c4d",
-		"editor.findMatchHighlightBackground": "#817c9c4d",
+		"editor.findMatchBackground": "#f6c177",
+		"editor.findMatchForeground": "#e0def4",
+		"editor.findMatchHighlightBackground": "#f6c1774d",
+		"editor.findMatchHighlightForeground": "#232136",
 		"editor.findRangeHighlightBackground": "#817c9c4d",
 		"editor.findRangeHighlightBorder": "#0000",
 		"editor.focusedStackFrameHighlightBackground": "#817c9c26",

diff --git a/themes/rose-pine-no-italics-color-theme.json b/themes/rose-pine-no-italics-color-theme.json
@@ -69,8 +69,10 @@
 		"dropdown.foreground": "#e0def4",
 		"dropdown.listBackground": "#1f1d2e",
 		"editor.background": "#191724",
-		"editor.findMatchBackground": "#6e6a8666",
-		"editor.findMatchHighlightBackground": "#6e6a8666",
+		"editor.findMatchBackground": "#f6c177",
+		"editor.findMatchForeground": "#e0def4",
+		"editor.findMatchHighlightBackground": "#f6c1774d",
+		"editor.findMatchHighlightForeground": "#191724",
 		"editor.findRangeHighlightBackground": "#6e6a8666",
 		"editor.findRangeHighlightBorder": "#0000",
 		"editor.focusedStackFrameHighlightBackground": "#6e6a8633",