Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include large internal lakes #268

Merged
merged 14 commits into from
Nov 11, 2024
Merged

Include large internal lakes #268

merged 14 commits into from
Nov 11, 2024

Conversation

rosepearson
Copy link
Owner

@rosepearson rosepearson commented Nov 6, 2024 •
edited
Loading

  • Fixes related to river inclusion
  • Support lakes much the same way as rivers
  • Fix patches spelling
  • Update functions names for adding rivers, lakes, waterways, stopbanks

DESCRIPTION OF PR:

  • Make code change
  • Update tests
    • Update / create new tests
    • Ensure these tests have the expected behavour
    • Test locally and ensure tests are passing
  • Ensure tests passing on GH Actions
  • Update documentation
    • Doc strings
    • Wiki
  • Update package (version.py & pyproject.toml) version (if needed)

@rosepearson rosepearson linked an issue Nov 6, 2024 that may be closed by this pull request
Large internal lakes: Add support for multiple regions & sources of contour data #154
Closed
github-actions and others added 12 commits November 6, 2024 22:40
fixup: Format Python code with Black
3c4cffd
@rosepearson
Added lakes and added a test
6abd7d0
fixup: Format Python code with Black
1838b97
@rosepearson
renamed to make functions more general
dc96f5b
@rosepearson
merge changes
0521553
fixup: Format Python code with Black
643d76d
@rosepearson
Update version
b5ee534
@rosepearson
Merge branch '154-large-internal-lakes-add-support-for-multiple-regio…
b1bbe0e 
…ns-sources-of-contour-data' of github.com:rosepearson/GeoFabrics into 154-large-internal-lakes-add-support-for-multiple-regions-sources-of-contour-data
@rosepearson
Update tests.yml
260c3fb 
Migrate from mamba-forge
@rosepearson
Merge branch '154-large-internal-lakes-add-support-for-multiple-regio…
7c352e4 
…ns-sources-of-contour-data' of github.com:rosepearson/GeoFabrics into 154-large-internal-lakes-add-support-for-multiple-regions-sources-of-contour-data
@rosepearson
Updated tests for new Westport tiles
abe53b2
@rosepearson
fixed spelling of patches.
30abc93
@rosepearson rosepearson added this to the 1.1.24 milestone Nov 11, 2024
@rosepearson rosepearson merged commit dcc694f into main Nov 11, 2024
3 checks passed
@rosepearson rosepearson deleted the 154-large-internal-lakes-add-support-for-multiple-regions-sources-of-contour-data branch November 11, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.24
Development

Successfully merging this pull request may close these issues.

Large internal lakes: Add support for multiple regions & sources of contour data
1 participant
@rosepearson