fix(models:document): define creator attribute as optional
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OndraSlama
changed the title
creator as optionalcreator attribute as optional
Codecov Report
@@ Coverage Diff @@
## main #35 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 28 28
Lines 1648 1648
=======================================
Hits 1630 1630
Misses 18 18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
We were trying to find the sweet spot between useful validation of data returned from Elis backend and stability, i.e. we're not raising exceptions if the backend returns an extra attribute (attributes are added to endpoints quite often) but I believe it is very usefel to know the user is provided with the expected type when convering JSONs to dataclasses. |
|
btw. |
asgeirrr
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This created hard-to-debug problem because some of the documents being fetched had
creator==None.I think we should maybe consider less strict validation for our internal data models unless we are super confident all are always up to date and correct. Because this can cause quite annoying problems in client code.