Accept colon-prefixed keywords in sexp macro.
#96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotty
pushed a commit
that referenced
this pull request
May 31, 2024
Implementation by @samuel-jimenez in PR #96. Duplicate of #96, closes #99.
rotty
pushed a commit
that referenced
this pull request
May 31, 2024
Implementation by @samuel-jimenez in PR #96. Duplicate of #96, closes #99.
rotty
pushed a commit
that referenced
this pull request
May 31, 2024
Implementation by @samuel-jimenez in PR #96. Duplicate of #96, closes #99.
rotty
pushed a commit
that referenced
this pull request
May 31, 2024
Implementation by @samuel-jimenez in PR #96. Duplicate of #96, closes #99.
rotty
pushed a commit
that referenced
this pull request
May 31, 2024
Implementation by @samuel-jimenez in PR #96. Duplicate of #96, closes #99.
|
Thanks for your contribution, @samuel-jimenez! I merged your changes in PR #101, squashing it and adding a bit of documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the macro considers the colon character to be a separator, and so splits tokens along the boundary.
e.g.,
sexp!((:name "Jane Doe" :street "4026 Poe Lane"))produces
(: name "Jane Doe" : street "4026 Poe Lane")This change allow colon-prefixed (Emacs-style) keywords (
:namein addition to#:name).