Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lexers/haskell: Recognize hs-boot files as Haskell #1060

Merged
merged 2 commits into from
Jun 19, 2019

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Jan 7, 2019

hs-boot files are used by GHC, the most widely used Haskell implementation.

`hs-boot` files are used by GHC, the most widely used Haskell implementation.
@bgamari
Copy link
Contributor Author

bgamari commented Feb 13, 2019

Ping?

@pyrmont
Copy link
Contributor

pyrmont commented May 28, 2019

@bgamari Sorry it took a while for this to get attention :( We generally like to have the filetypes that are registered for lexers tested in the relevant spec. Would you be able to make an update in the relevant section?

it 'guesses by filename' do
assert_guess :filename => 'foo.hs'
end

@pyrmont pyrmont added the author-action The PR has been reviewed but action by the author is needed label May 28, 2019
@pyrmont pyrmont merged commit fea945e into rouge-ruby:master Jun 19, 2019
@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Jun 19, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Jun 19, 2019

@bgamari I hope you don't mind but I took the liberty of pushing directly to your branch to update this PR. The result has now been merged.

Thanks for contributing to Rouge! It's a better library because of this PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants