Improve support for single quotes in Haskell lexer #1524
Conversation
|
@Fresheyeball The problem you were encountering with your code was actually due to the fact that Rouge was treating The idiomatic way to fix that in Rouge is to have a more general rule for matching names that can then take advantage of Array's It looks to me like this fixes the problem without introducing any regressions but let me know if you have any feedback! |
|
Looks good to me! 😄 Can't wait for this to make it's way to Gitlab |
|
@Fresheyeball We release new versions of Rouge on a monthly cadence. This will be part of v3.20.0 and will go out to RubyGems on Tuesday 9 June. I'm not sure how regularly GitLab pulls in a new version of the library but I imagine it should arrive pretty soon! 🎉 |
Haskell uses matching single quotes to express character literals (e.g. `'A'`). However, the unmatched single quote character, `'`, is also used for various purposes (e.g. as part of a variable name like `x'` or in the name of a promoted type like `'Bar`). Currently, Rouge's Haskell lexer permits the use of an unmatched single quote by having separate rules for naming and then a general rule of lower precedence for when the lexer encounters `'`. A better approach would be to only treat `'` as being part of a character literal if the lexer detects that there is a matching `'` within an appropriate number of characters. This commit does that and then creates a more general rule for matching names.
Haskell uses matching single quotes to express character literals (e.g.
'A'). However, the unmatched single quote character,', is also used for various purposes (e.g. as part of a variable name likex'or in the name of a promoted type like'Bar). Currently, Rouge's Haskell lexer permits these use of unmatched single quote by having separate rules for naming and then a general rule of lower precedence for when the lexer encounters'.A better approach would be to only treat
'as being part of a character literal if the lexer detects that there is a matching'within an appropriate number of characters. This PR does that and then creates a more general rule for matching names.This fixes #1514.