Add Nial Lexer #1803
Closed
Add Nial Lexer #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tancnle
reviewed
Jun 29, 2022
There was a problem hiding this comment.
Thank you for your contribution @razetime ❤️ The PR looks good to me overall.
It seems that the CI hasn't run on this PR yet. Could you kindly rebase this off the master branch?
We use a 2-space indentation for Ruby in this code base. Could you fix this?
We would like to run Rubocop linting against the minimum supported Ruby version, that is 2.5. Profile and warnings will be run against the latest version of Ruby 3.1 so we can preempt upcoming issues.
Comparing the names is much less efficient than comparing the instance directly. It may also change in the future: https://bugs.ruby-lang.org/issues/18576
Update the lexer for syzlang DSL to allow processing inputs with lists and syscall arguments replaced with "...". This is useful for highlighting snippets that are shortened for readability. Also add tests for the new behavior. Signed-off-by: Andrey Konovalov <[email protected]>
* initial support for lean 3 * incorporate keywords and operators from PR rouge-ruby#1019 * address comments * add keyword::type + other keywords
…#1809) * Fix notation of named stages in multi-stage docker builds * Check for whitespace as well to mitigate "AS" appearing in image names * Add multi-stage builder pattern to sample
Newly introduced "keywords": `arguments, properties, methods, import`
* add oracle plsql lexer * add demo and sample * tweak rules for multiline items and function/package/procedure/type creates * add type attributes, word operators, preprocessor directives * add rule for MERGE syntax to get keywords rather than names * remove trailing dot option for floating point number. restrict words after dot to functions or regular names instead of keywords * pad visual sample with more edge cases on numbers and dot method notation. Add comments to lexer code and pretty it up * added PLSQL to docs/Languages.md ensure 2 space indentation throughout correct spelling errors in comments change keywords to keywords_reserved and keywords_nresvd to keywords Remove redundant comments add cursor attributes to name::attribute list add optional double/float modifier letters to numeric literals, also to visual test file. * slight formatting tweak. remove extra space
This updates our Code of Conduct based on the Contributor Covenant v2.1.
* feat(lexer): Added isabelle lexer * fix(isabelle-lexer): improved keyword handling * feat(isabelle-lexer): improved name handling in edge cases * feat(isabelle-lexer): improved examples * feat(isabelle-lexer): improved examples * feat(isabelle-lexer): added alias for pygments interop * feat(isabelle-lexer): better code style, add to languages * feat(isabelle-lexer): more efficient parsing Co-authored-by: Fabian Huch <[email protected]>
…ifier, etc.) (rouge-ruby#1829) * PHP: add missing keywords * `empty` * `match` * `readonly` * `unset` cf. https://www.php.net/manual/en/reserved.keywords.php * PHP: fix parsing of static properties Previously, static property declaration with type hint like `public static int $x;` was parsed as the following: * Keyword (`public`) * Keyword (`static`) * Unknown token (`int`) * Variable (`$x`) `int` should be parsed as a type. The previous parser state `:in_visibility` defines these rules: ```ruby state :in_visibility do rule %r/(?=(abstract|const|function|static)\b)/i, Keyword, :pop! rule %r/\??#{id}/, Keyword::Type, :pop! # ... end ``` Because a parser pops the current state once it find `static`, it cannot recognize a type hint following the `static` keyword. I split the rule into two, `static` and other. If a parser encounters `static`, it stays in the current state and then parses a type hints. * PHP: support `readonly` modifier * PHP: support constructor property promotion Since PHP 8.0, you can prepend visibility modifiers to parameters of constructors. These parameters are "promoted" to class properties. Since 8.1, you can specify `readonly` modifier as class properties. cf. https://www.php.net/manual/en/language.oop5.decon.php#language.oop5.decon.constructor.promotion * PHP: add some visual tests
…ruby#1836) * Support more Jenkins pipeline name variations in groovy lexer Support *.Jenkinsfile patters * Add missing spec to groovy
|
i've done the rebase. I hope this is correct. |
|
Thanks, @razetime. It seems that the rebase has gone awry with all the extra commits that are already in the upstream master branch. Generally, we would create a feature branch on your fork instead of using the
|
|
Continued in #1844. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For use in the main Nial language website: https://nial-array-language.org/