-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Visual Studio and Delphi project file types to the XML lexer #764
Conversation
Thanks. The PR should work as expected, but I wonder why the XML lexer can't guess the file type for them. Maybe improving |
Guessing works just fine without this PR for me. All my Visual Studio 2015 C/C++/Fortran files ( <?xml version="1.0" encoding="UTF-8"?>
<Project DefaultTargets="Build" ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> |
Works for me in GitLab... 😕 |
Gessing should be improved after #763 |
@gfx As mentioned, I cannot reproduce the problem anyways. |
Since GitLab users are here - did you know you can manually override guessing with your |
I've found the culprit: my csproj files have an UTF8 BOM at the start of the file (they are saved this way by default). If I remove them, GitLab successfully guesses the type of these files. As UTF8 BOM is a pretty common thing, it should not be a blocker of detecting the type of a file. |
Still, I don't think the approach of this PR is the right solution for that problem. Maybe you can file a new issue and close this PR @qcz? |
Done. See #767. |
Added the following file types to the XML lexer:
csproj
: Microsoft Visual Studio C# project filevbproj
: Microsoft Visual Studio Visual Basic project filedproj
: Embarcadero Delphi Project FileThe content of these file types is standard XML.