Skip to content
This repository has been archived by the owner on Jul 7, 2020. It is now read-only.

Replace bootstrap popovers with something that works #17

Closed
alecpl opened this issue Mar 10, 2017 · 7 comments
Closed

Replace bootstrap popovers with something that works #17

alecpl opened this issue Mar 10, 2017 · 7 comments

Comments

@alecpl
Copy link
Member

alecpl commented Mar 10, 2017

I was struggling with using bootstrap4's popover widget for Roundcube popup menus. This is so buggy and fragile solution that I failed. So, we'd need to wait until they fix it or rather find another solution (i.e. copy the custom code from Larry).

@thomascube
Copy link
Member

Don't forget about accessibility (keyboard control, etc.) ;-)

@alecpl
Copy link
Member Author

alecpl commented Mar 26, 2017

https://popper.js.org/ looks interesting. Probably still much work to implement all we need.

@alecpl
Copy link
Member Author

alecpl commented Mar 28, 2017

And BTW, if we replace Bootstrap's popovers with something other or we don't get Bootstrap4 in Q3-2017 I would consider abandoning Bootstrap in favor of https://purecss.io or sth like that.

@pom2ter
Copy link

pom2ter commented Apr 6, 2017

Thats one of the disadvantages when something is in alpha; any feature may be broken or buggy.
What exactly is the issue? And, i dont think i saw this one mentionned in all the exchange i've seen between you and Marc, why Bootstrap 4 instead of the very stable 3?

@alecpl
Copy link
Member Author

alecpl commented Apr 7, 2017

I see they fixed some issues recently, so maybe beta will be usable. We target the end of year that's why I wanted to use most recent version, hoping Bootstrap4 will be ready or almost ready at that time. Anyway, our popover menus will be quite sophisticated, with multi-level popups and mobile support. So, we may need to implement this without bootstrap.

@alecpl
Copy link
Member Author

alecpl commented Apr 15, 2017

FYI, looks like Bootstrap is also considering switching from tether to popper. https://github.com/twbs/bootstrap/pull/22444/files

@alecpl
Copy link
Member Author

alecpl commented May 25, 2017

Implemented with most recent Bootstrap4 build.

@alecpl alecpl closed this as completed May 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants