Use full changeset hash for 3rd-party GitHub Actions #48
+58
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masutaka
commented
Jun 26, 2024
| @@ -25,4 +25,4 @@ jobs: | |||
| if: ${{ github.event.pull_request.user.type != 'Bot' && toJSON(github.event.pull_request.assignees) == '[]' }} | |||
|
|
|||
| steps: | |||
| - uses: technote-space/assign-author@v1 | |||
| - uses: technote-space/assign-author@9558557c5c4816f38bd06176fbc324ba14bb3160 # v1.6.2 | |||
There was a problem hiding this comment.
| @@ -31,4 +31,4 @@ jobs: | |||
| timeout-minutes: 5 | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| - uses: ls-lint/[email protected] | |||
| - uses: ls-lint/action@1887e6c0e7f2dfa81a2d67591f0eb7782720026f # v2.2.3 | |||
There was a problem hiding this comment.
| @@ -31,7 +31,7 @@ jobs: | |||
| COMMIT_MESSAGE: ${{ github.event.head_commit.message }} | |||
| run: echo "COMMIT_MESSAGE=$COMMIT_MESSAGE" | tr '\n' ' ' >> "$GITHUB_ENV" | |||
| - name: Notify to slack | |||
| uses: tokorom/action-slack-incoming-webhook@main | |||
| uses: tokorom/action-slack-incoming-webhook@d57bf1eb618f3dae9509afefa70d5774ad3d42bf # v1.3.0 | |||
There was a problem hiding this comment.
|
ありがとうございます！🚀 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更内容
サードパーティの GitHub Actions のバージョンを Full Changeset Hash での固定に変更する。
👈 の GitHub Actions について、変更した
背景・目的
このリポジトリ https://github.com/route06/actions をよりセキュアにするため。
🔗 社内用GitHub Actionsのセキュリティガイドラインを公開します | メルカリエンジニアリング
Dependabot は Full Changeset Hash に対応している3ため、Full Changeset Hash に変更するデメリットはサードパーティの GitHub Action を初めて導入する時だけ。
TODO
関連情報
Footnotes
GitHub Marketplace に公開されていない理由: https://github.com/github/codeql-action/issues/596#issuecomment-868569180 ↩ ↩2 ↩3
GitHub Marketplace に公開されていない ↩
https://github.com/route06/actions/pull/46#discussion_r1650261916 ↩