Convert to Java Strings only for sketch metric columns of StringType #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| value = new String(((UTF8String) value).getBytes(), StandardCharsets.UTF_8); | ||
| if (value != null && segmentSpec.getComplexMetricColumns().contains(columnName) && sqlType == DataTypes.StringType) { | ||
| // Convert to Java String as Spark return UTF8String which is not compatible with Druid sketches. | ||
| value = value.toString(); |
There was a problem hiding this comment.
What is this change about (this line)?
There was a problem hiding this comment.
value here when the field is StringType is of instance https://spark.apache.org/docs/1.4.0/api/java/org/apache/spark/sql/types/UTF8String.html.
The change here is coerce it to Java string
https://spark.apache.org/docs/1.4.0/api/java/org/apache/spark/sql/types/UTF8String.html#toString()
There was a problem hiding this comment.
calling toString() on UTF8String object is same as the previous code.
I changed to toString() to simplify the code to avoid checking if object is instance of UTF8String.
juhoautio-rovio
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR avoids the performance degradation due to too many object creation as noticed in #44.
With this change, only String metric columns used in sketches are converted to Java String type.