Fix trailing color in new lines #23
Conversation
When the output is constructed, new lines are included in the colored string. <img src="http://i.imgur.com/DthTZXz.png"> <img src="http://i.imgur.com/nsiFALg.png">
|
Whoa ! The unit tests are nearly impossible to make out. There's two reasons why the build is failing:
I can fix the first issue, but the second is nearly impossible to make out. Those tests 'results.txt' are not human friendly. |
|
@eladchen. I can help with the other tests. fix the beautify and push, I can help with the tests. They are more like snapshot testing than actually unit testing (I mean I was not expecting a human generating those outputs :) ) In any case as I said I can fix those once beautification is fixed. |
| @@ -55,7 +55,7 @@ var getKeyLink = function(key) { | |||
| }; | |||
|
|
|||
| var printSummary = function(hash, title, method) { | |||
| var res = '\n\n' + chalk[method](title + ':\n'); | |||
| var res = '\n\n' + chalk[method](title + ':') + chalk.white('\n'); | |||
There was a problem hiding this comment.
mmm, not sure it should be white, why not just \n instead? with no color control chars?
There was a problem hiding this comment.
Using plain '\n' doesn't preserve new lines when it is printed with gulp, I assume gulp is trimming the log before outputting it.
|
Sorry man for the long delay on this branch, can you run |
|
I'll do it asap. |
|
I manually merged this PR. thanks @eladchen Sorry for the big delay in working on this. |
When the output is constructed, new lines are included in the colored string.