-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use internal pull-up in pico_spi_sd_card example #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ithinuel
force-pushed
the
experiment-gpio-overhaul
branch
from
May 22, 2023 05:35
76fa8bf
to
1c177f3
Compare
ithinuel
force-pushed
the
experiment-gpio-overhaul
branch
2 times, most recently
from
May 22, 2023 05:38
274b672
to
6bde20a
Compare
ithinuel
force-pushed
the
experiment-gpio-overhaul
branch
from
May 29, 2023 13:02
6bde20a
to
a6fbf54
Compare
ithinuel
force-pushed
the
experiment-gpio-overhaul
branch
from
August 15, 2023 07:17
a6fbf54
to
5fd8238
Compare
This was referenced Aug 15, 2023
jannic
reviewed
Aug 18, 2023
I think rp-rs/rp-hal#585 also changed the diff --git a/boards/rp-pico/src/lib.rs b/boards/rp-pico/src/lib.rs
index 1b574f4..c664eb2 100644
--- a/boards/rp-pico/src/lib.rs
+++ b/boards/rp-pico/src/lib.rs
@@ -83,17 +83,17 @@ hal::bsp_pins!(
name: gpio0,
aliases: {
/// UART Function alias for pin [crate::Pins::gpio0].
- FunctionUart: Gp0Uart0Tx,
+ FunctionUart, PullNone: Gp0Uart0Tx,
/// SPI Function alias for pin [crate::Pins::gpio0].
- FunctionSpi: Gp0Spi0Rx,
+ FunctionSpi, PullNone: Gp0Spi0Rx,
/// I2C Function alias for pin [crate::Pins::gpio0].
- FunctionI2C: Gp0I2C0Sda,
+ FunctionI2C, PullNone: Gp0I2C0Sda,
/// PWM Function alias for pin [crate::Pins::gpio0].
- FunctionPwm: Gp0Pwm0A,
+ FunctionPwm, PullNone: Gp0Pwm0A,
/// PIO0 Function alias for pin [crate::Pins::gpio0].
- FunctionPio0: Gp0Pio0,
+ FunctionPio0, PullNone: Gp0Pio0,
/// PIO1 Function alias for pin [crate::Pins::gpio0].
- FunctionPio1: Gp0Pio1
+ FunctionPio1, PullNone: Gp0Pio1
}
},
< etc> |
ithinuel
changed the title
Update to use the overhauled GPIO API
Use internal pull-up in pico_spi_sd_card example
Aug 28, 2023
jannic
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: