Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spareirq interrupts #8

Merged
merged 3 commits into from
Dec 22, 2024
Merged

Add spareirq interrupts #8

merged 3 commits into from
Dec 22, 2024

Conversation

9names
Copy link
Member

@9names 9names commented Dec 7, 2024

Alternative to #5 that reuses the names from rp2040-pac.
Keeps the descriptions the same though, so anyone searching the docs for the names in the reference manual should find them.

Also fixed some build script issues, because I couldn't rebuild the PAC otherwise.
CI fixes are now in a separate PR

@jannic
Copy link
Member

jannic commented Dec 10, 2024

I agree that rp2040-pac and rp235x-pac should use the same names. In case a future upstream SVD adds these interrupts, I'd want to remove our patch, which may introduce a breaking change. But until then, let's use the current names from rp2040-pac for rp235x-pac.

@9names 9names added this pull request to the merge queue Dec 22, 2024
Merged via the queue into rp-rs:main with commit 91bb7eb Dec 22, 2024
6 checks passed
@9names 9names mentioned this pull request Dec 22, 2024
@9names 9names deleted the spareirq branch December 22, 2024 11:47
@9names 9names mentioned this pull request Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants