Merge pull request #10 from rpkamp/simplify-subject-check

Add test to prove parsing empty subject works correctly
rpkamp · Aug 7, 2018 · 2bf6a4f · 2bf6a4f
2 parents 4f9f9e9 + 9b8a587
commit 2bf6a4f
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/Message/MessageFactory.php b/src/Message/MessageFactory.php
@@ -18,7 +18,7 @@ public static function fromMailhogResponse(array $mailhogResponse): Message
             ContactCollection::fromString($headers['To'][0] ?? ''),
             ContactCollection::fromString($headers['Cc'][0] ?? ''),
             ContactCollection::fromString($headers['Bcc'][0] ?? ''),
-            isset($headers['Subject'][0]) ? $headers['Subject'][0] : '',
+            $headers['Subject'][0] ?? '',
             !$mimeParts->isEmpty()
                 ? $mimeParts->getBody()
                 : static::getBodyFrom($mailhogResponse['Content']),

diff --git a/tests/integration/MailhogClientTest.php b/tests/integration/MailhogClientTest.php
@@ -73,6 +73,21 @@ public function it_should_receive_all_message_data()
         $this->assertEquals('Test body', $message->body);
     }
 
+    /**
+     * @test
+     */
+    public function it_should_handle_message_without_subject_correctly()
+    {
+        $this->sendMessage(
+            $this->createBasicMessage('[email protected]', '[email protected]', '', 'Test body')
+        );
+
+        /** @var Message $message */
+        $message = iterator_to_array($this->client->findAllMessages())[0];
+
+        $this->assertEquals('', $message->subject);
+    }
+
     /**
      * @test
      */