Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it possible to not use json with Postgres #86

Closed
wants to merge 1 commit into from

Conversation

diwu1989
Copy link
Contributor

using json field in postgres causes issues with aggregates and distinct because of missing equality checkers for the json columns.

there should be a way to opt-out of the postgres json column optimization

@diwu1989
Copy link
Contributor Author

This should give a way out for folks who are having problem with #57

@diwu1989
Copy link
Contributor Author

This may also solve #55

@bradjasper
Copy link
Collaborator

Hey @diwu1989 thanks for this. I'm actually in the process of removing PG json support entirely as it's caused nothing but problems. The next major release (with Django 1.7) will provide a breaking change here so this may not be needed anymore.

In the meantime you can use https://github.com/bradjasper/django-jsonfield/tree/postgresql if you're looking for something that will be supported.

@bradjasper bradjasper closed this Jun 25, 2014
@diwu1989
Copy link
Contributor Author

aha! nice work, thank you very much.

Premature optimization is the root of all evils, die json column die.

@ravishivt
Copy link

@bradjasper Can you source what Django 1.7 will be doing differently in regards to this problem?

IMO, removing support for PG json field types is a step backwards. You lose the performance gains and the psql JSON querying API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants