Make rqstats -y fail when PyYAML is not installed
#660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when PyYAML is not installed, `rqstats -y` prints an error message, but it still exits with a 0 exit code, indicating success. Fix that, along with a few related issues: * The error message was printed to stdout rather than stderr. * The name of the library in the message was incorrect (LibYAML is a C library; the Python library is PyYAML). After this change, you need to install PyYAML to run the testsuite, so modify the GitHub workflow accordingly. Also, make sure to install all packages at once, to make sure that later install commands don't overwrite the result of the earlier ones.
|
Thanks! |
alaouimehdi1995
pushed a commit
to alaouimehdi1995/django-rq
that referenced
this pull request
Sep 3, 2024
Currently, when PyYAML is not installed, `rqstats -y` prints an error message, but it still exits with a 0 exit code, indicating success. Fix that, along with a few related issues: * The error message was printed to stdout rather than stderr. * The name of the library in the message was incorrect (LibYAML is a C library; the Python library is PyYAML). After this change, you need to install PyYAML to run the testsuite, so modify the GitHub workflow accordingly. Also, make sure to install all packages at once, to make sure that later install commands don't overwrite the result of the earlier ones.
alaouimehdi1995
pushed a commit
to alaouimehdi1995/django-rq
that referenced
this pull request
Sep 3, 2024
Currently, when PyYAML is not installed, `rqstats -y` prints an error message, but it still exits with a 0 exit code, indicating success. Fix that, along with a few related issues: * The error message was printed to stdout rather than stderr. * The name of the library in the message was incorrect (LibYAML is a C library; the Python library is PyYAML). After this change, you need to install PyYAML to run the testsuite, so modify the GitHub workflow accordingly. Also, make sure to install all packages at once, to make sure that later install commands don't overwrite the result of the earlier ones.
alaouimehdi1995
pushed a commit
to alaouimehdi1995/django-rq
that referenced
this pull request
Sep 3, 2024
Currently, when PyYAML is not installed, `rqstats -y` prints an error message, but it still exits with a 0 exit code, indicating success. Fix that, along with a few related issues: * The error message was printed to stdout rather than stderr. * The name of the library in the message was incorrect (LibYAML is a C library; the Python library is PyYAML). After this change, you need to install PyYAML to run the testsuite, so modify the GitHub workflow accordingly. Also, make sure to install all packages at once, to make sure that later install commands don't overwrite the result of the earlier ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when PyYAML is not installed,
rqstats -yprints an error message, but it still exits with a 0 exit code, indicating success. Fix that, along with a few related issues:The error message was printed to stdout rather than stderr.
The name of the library in the message was incorrect (LibYAML is a C library; the Python library is PyYAML).
After this change, you need to install PyYAML to run the testsuite, so modify the GitHub workflow accordingly. Also, make sure to install all packages at once, to make sure that later install commands don't overwrite the result of the earlier ones.