Fix incompatibility with dart 3 #917
Conversation
| if (displayType.contains('InvalidType')) { | ||
| displayType = displayType.replaceAll('InvalidType', 'dynamic'); | ||
| } |
There was a problem hiding this comment.
There must be a better way to do this. Rather than matching for the InvalidType string, it would be better to check that the type is an InvalidType dart type
|
Hello! This would need tests :) Could you maybe add a class which does: @freezed
class Example with _$Example {
factory Example(
CodeGenerated a,
List<CodeGenerated> b,
List<List<CodeGenerated>> c,
) = _Example;
} |
|
Ok I'm so sorry ... I opened a new PR #921 without checking that this one already exists 🙈. |
@SunlightBro Not a problem! Your PR looks much more sophisticated. Although it would be cool to have my name in the freezed contributors section, I'm all for correctness. Feel free to close this if your PR solves a superset of what this one solves 😁 I'll hold off writing tests for this PR until then |
|
I'll close this then. But I really appreciate your effort :) |
This is a very crude attempt at fixing an
InvalidTypecode generation issue. I've isolated the problem to these two spots in the code base.fixes #916