apply Justin's suggestion

End the RAF loop when the recorder stops
rrweb-io · Mar 23, 2023 · 5f4bd8a · 5f4bd8a
1 parent 26201a3
commit 5f4bd8a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/packages/rrweb/src/record/index.ts b/packages/rrweb/src/record/index.ts
@@ -615,6 +615,7 @@ function record<T = eventWithTime>(
     }
     return () => {
       handlers.forEach((h) => h());
+      processedNodeManager.destroy();
       recording = false;
       unregisterErrorHandler();
     };

diff --git a/packages/rrweb/src/record/processed-node-manager.ts b/packages/rrweb/src/record/processed-node-manager.ts
@@ -5,6 +5,8 @@ import type MutationBuffer from './mutation';
  */
 export default class ProcessedNodeManager {
   private nodeMap: WeakMap<Node, Set<MutationBuffer>> = new WeakMap();
+  // Whether to continue RAF loop.
+  private loop = true;
 
   constructor() {
     this.periodicallyClear();
@@ -13,7 +15,7 @@ export default class ProcessedNodeManager {
   private periodicallyClear() {
     requestAnimationFrame(() => {
       this.clear();
-      this.periodicallyClear();
+      if (this.loop) this.periodicallyClear();
     });
   }
 
@@ -31,4 +33,9 @@ export default class ProcessedNodeManager {
   private clear() {
     this.nodeMap = new WeakMap();
   }
+
+  public destroy() {
+    // Stop the RAF loop.
+    this.loop = false;
+  }
 }