fix(web-extension): beforeunload logic (#1330)

rrweb-io · Nov 3, 2023 · 9e65dda · 9e65dda
1 parent 05478c3
commit 9e65dda
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/witty-kids-talk.md b/.changeset/witty-kids-talk.md
@@ -0,0 +1,5 @@
+---
+'@rrweb/web-extension': patch
+---
+
+🐞 fix(web-extension): beforeunload logic
diff --git a/packages/web-extension/src/content/index.ts b/packages/web-extension/src/content/index.ts
@@ -155,8 +155,8 @@ async function initMainPage() {
 
   // Before unload pages, cache the new events in the local storage.
   window.addEventListener('beforeunload', (event) => {
+    if (!newEvents.length) return;
     event.preventDefault();
-    if (newEvents.length === 0) return;
     void Browser.storage.local.set({
       [LocalDataKey.bufferedEvents]: bufferedEvents.concat(newEvents),
     });