fix: remote CSS does not get rebuilt properly

[billyvg]

This fixes an issue where inlined CSS from a remotely loaded <link> does not get applied properly due to object reference mutation.

[changeset-bot]

🦋 Changeset detected

Latest commit: f398551

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages

Name	Type
rrweb	Patch
rrweb-snapshot	Patch
rrdom	Patch
rrdom-nodejs	Patch
rrweb-player	Patch
@rrweb/all	Patch
@rrweb/replay	Patch
@rrweb/record	Patch
@rrweb/types	Patch
@rrweb/packer	Patch
@rrweb/utils	Patch
@rrweb/web-extension	Patch
rrvideo	Patch
@rrweb/rrweb-plugin-console-record	Patch
@rrweb/rrweb-plugin-console-replay	Patch
@rrweb/rrweb-plugin-sequential-id-record	Patch
@rrweb/rrweb-plugin-sequential-id-replay	Patch
@rrweb/rrweb-plugin-canvas-webrtc-record	Patch
@rrweb/rrweb-plugin-canvas-webrtc-replay	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[eoghanmurray]

I can't make changes directly on this branch;

Would you be able to

• add a changeset
• cherry-pick the following commit so that the tests pass: c8b0595

[eoghanmurray]

The Object.assign bit was introduced in #995
I'm wondering if it had special significance there in terms of how the link element is updated ... have pinged Yun.

[YunFeng0817]

@billyvg The only difference is that Object.assign overwrites the attribute value in the mirror. Your change does not change the meta in the mirror.
Can you please help me understand why this difference can cause the bug?

[billyvg]

@YunFeng0817 Yeah so I'm not sure if we are relying on changing the meta in the mirror elsewhere. The reason for this change is as follows:

• buildNodeWithSN() is called with the meta from mirror
• Inside of buildNodeWithSN, we check if the meta in mirror is equal to itself

[YunFeng0817]

@billyvg Thank you for the clean explanation. I now understand the cause of the issue.
buildNodeWithSN() is called with the meta from mirror I made this for preventing duplicate nodes in the replayer. But a remotely loaded is an exception for the check.

Can you add

Object.assign(
  newSn.attributes,
  mutation.attributes as attributes,
);

to the place after the newNode is created? This can keep the mirror sync with Dom status

[billyvg]

@YunFeng0817 Updated!

[YunFeng0817]

LGTM