Tweaks to timings to get tests passing on my dev laptop #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…his makes tests more deterministic
|
Ok so the upshot of this pull request is that I've shifted the Are there any other approaches we could take, e.g. instead of sleeping for 500ms, sleep for (500ms - time_already_expended)? |
eoghanmurray
added a commit
to statcounter/rrweb
that referenced
this pull request
Feb 3, 2021
* Tweaks to timings to get tests passing on my dev laptop - hopefully this makes tests more deterministic * Okay understand what's going on now that the test has run in the travis environment
eoghanmurray
added a commit
to statcounter/rrweb
that referenced
this pull request
Feb 22, 2021
* Tweaks to timings to get tests passing on my dev laptop - hopefully this makes tests more deterministic * Okay understand what's going on now that the test has run in the travis environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this makes tests more deterministic...
This pull request is more to get the conversation started on how variations between test runs should be managed.
In particular, I've added the following comment:
rrweb/test/record.test.ts
Line 143 in 10842b4
I'm not sure if the above change is in fact correct; but if not, it would be good to find out what the reason for waiting 500ms here is?