Don't perform newly added actions if player is paused #539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've a scenario where newly added events which are coming in after the current play position are affecting the player state even when the player is paused.
I believe the correct thing to do (as per this pull request) is not to execute them until the player is resumed.
I see that starting the
timer.start();
line was added as part of #161 but I can't quiet understand what the idea was there?I've changed it to instead only queue up the event if the timer is currently executing, which makes more sense to me, but I might be missing something?