Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't perform newly added actions if player is paused #539

Merged
merged 1 commit into from
Apr 18, 2021

Conversation

eoghanmurray
Copy link
Contributor

I've a scenario where newly added events which are coming in after the current play position are affecting the player state even when the player is paused.
I believe the correct thing to do (as per this pull request) is not to execute them until the player is resumed.
I see that starting the timer.start(); line was added as part of #161 but I can't quiet understand what the idea was there?
I've changed it to instead only queue up the event if the timer is currently executing, which makes more sense to me, but I might be missing something?

@Yuyz0112
Copy link
Member

@eoghanmurray Yes, I believe it's a bug in the original design.

@Yuyz0112
Copy link
Member

Thanks!

@Yuyz0112 Yuyz0112 merged commit 7c5e15d into rrweb-io:master Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants