Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.ts #63

Closed
wants to merge 1 commit into from
Closed

Update index.ts #63

wants to merge 1 commit into from

Conversation

MagnusDot
Copy link

Update for working in google chrome

Update for working in google chrome
@Yuyz0112
Copy link
Member

Hi @MagnusDot , the replay iframe sandbox was designed to be not allowed scripts. Is there any case your replayer is not working?

@MagnusDot
Copy link
Author

In all the case the replay player don't want to be opened without "allow-scripts"

@Yuyz0112
Copy link
Member

Okay, so you mean the replayer is not replaying correctly or you are just seeing some errors like:

Blocked autofocusing on a form control because the form's frame is sandboxed and the 'allow-scripts' permission is not set.

@MagnusDot
Copy link
Author

my error was exactly :
document's frame is sandboxed and the 'allow-scripts' permission is not set. rrweb

@MagnusDot
Copy link
Author

my error was exactly :
document's frame is sandboxed and the 'allow-scripts' permission is not set. rrweb

and with editing the sandbox options the problem passed away

@Yuyz0112
Copy link
Member

This was designed to work like this(except the error was not muted).

Further reading: https://github.com/rrweb-io/rrweb/blob/master/docs/sandbox.md#iframe-sandbox.

@MagnusDot
Copy link
Author

MagnusDot commented Apr 11, 2019

I can udersta,t it's a problem of security but if "allow-script" is not activate that's call the error and stop all the program

@Yuyz0112
Copy link
Member

Could you provide which website are you trying to record or provide some recorded events to me for debugging?

@MagnusDot
Copy link
Author

I'm trying to work on a local project i can give you the recorded event
https://pastebin.com/MGR6mrKR

@Yuyz0112
Copy link
Member

debug-2019-04-12_09.57.07.zip
I have replayed it and record a video, it looks like working correctly.

@MagnusDot
Copy link
Author

Did you use the Chrome one, thie is where the problem is

@Yuyz0112
Copy link
Member

Yes, I'm using chrome.
Could you provide your replayer code for debugging?

@MagnusDot
Copy link
Author

Yes i'm going to work and send it to you ^^

@MagnusDot
Copy link
Author

MagnusDot commented Apr 12, 2019

`<script>
function replay() {

    if (ontime == 0) {
        ontime = 1;
        const events = <?php echo file_get_contents('public/js/data.json'); ?>;


        new rrwebPlayer({
            target: document.getElementById("video"), // customizable root element
            data: {
                events,
                autoPlay: true,
            },
        });

    }


}

</script>`

@Yuyz0112
Copy link
Member

Sorry, still could not reproduce your issue.

@MagnusDot
Copy link
Author

MagnusDot commented Apr 14, 2019

Sorry, still could not reproduce your issue.

ha, so refuse my pull it's maybe my config, i've done some change it's working now for me ^^ 👍 thx for you're time =)

@Yuyz0112 Yuyz0112 closed this Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants