-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update index.ts #63
Update index.ts #63
Conversation
Update for working in google chrome
Hi @MagnusDot , the replay iframe sandbox was designed to be not allowed scripts. Is there any case your replayer is not working? |
In all the case the replay player don't want to be opened without "allow-scripts" |
Okay, so you mean the replayer is not replaying correctly or you are just seeing some errors like:
|
my error was exactly : |
and with editing the sandbox options the problem passed away |
This was designed to work like this(except the error was not muted). Further reading: https://github.com/rrweb-io/rrweb/blob/master/docs/sandbox.md#iframe-sandbox. |
I can udersta,t it's a problem of security but if "allow-script" is not activate that's call the error and stop all the program |
Could you provide which website are you trying to record or provide some recorded events to me for debugging? |
I'm trying to work on a local project i can give you the recorded event |
debug-2019-04-12_09.57.07.zip |
Did you use the Chrome one, thie is where the problem is |
Yes, I'm using chrome. |
Yes i'm going to work and send it to you ^^ |
`<script>
</script>` |
Sorry, still could not reproduce your issue. |
ha, so refuse my pull it's maybe my config, i've done some change it's working now for me ^^ 👍 thx for you're time =) |
Update for working in google chrome