fix: custom style rules don't get inserted into some iframe elements #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug
If an iframe element is added to the dom first and its document nodes are added later, the custom style rules won't get inserted.
reason
The custom style rules were designed to add through code . But when we apply the iframe's document content mutation later, the inserted style element would be wiped here.
idea of the fix
We can insert our custom rules whenever a new HTML element is appended to an iframe's content document. Because
attachDocumentToIframe's afterAppend callback seems to be the common execution path of all situations.