Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actual exceptions on requests to Mandrill server are not propagated #83

Open
thberger opened this issue Dec 7, 2017 · 0 comments
Open

Comments

@thberger
Copy link

thberger commented Dec 7, 2017

The execute() method of MandrillRequestDispatcher has a bug: If the request to Mandrill fails for some reason, the response object gets null. This in turn leads to a NPE in the finally block. When the method is finally left with the NPE, the original exception cause is gone - making debugging very hard.
This codesmell is also detected by SonarLint, by the way.

PR is incoming.

See also: https://next.sonarqube.com/sonarqube/coding_rules#rule_key=csharpsquid%3AS1163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant