Skip to content
This repository has been archived by the owner on Nov 7, 2023. It is now read-only.

Small Device Support #92

Merged
merged 4 commits into from
Oct 22, 2020
Merged

Small Device Support #92

merged 4 commits into from
Oct 22, 2020

Conversation

jessgusclark
Copy link
Member

Changes to accommodate smaller devices and Spanish language string length.

The majority of the files below in the preview show small edits. The larger edits are mostly removing the from the which required removing [tabs].

- Added <ScrollView> in <BackComponent>
- Remove <ScrollView> on screens that already implemented <BackComponent>.
- Add <ScrollView>  where back was not implemented but needed.
- Set width of the modal based on the device width
- Set width of the QR image based on its parent View
- Add padding to header on profile page so it isn't behind settings cog
- Add language string for spanish
- Remove duplicates in spanish JSON
@lgtm-com
Copy link

lgtm-com bot commented Oct 22, 2020

This pull request introduces 2 alerts when merging 2dd457b into 1214520 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

Copy link
Contributor

@ilanolkies ilanolkies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactor to QR Modal!

@ilanolkies ilanolkies merged commit a6611d7 into develop Oct 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the shorty branch October 22, 2020 15:21
@ilanolkies ilanolkies mentioned this pull request Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants