This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
feat: staking #112
Closed
feat: staking #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianmrodri
suggested changes
Aug 20, 2020
contracts/Staking.sol
Outdated
| @@ -0,0 +1,45 @@ | |||
| pragma solidity 0.6.2; | |||
|
|
|||
| import "./vendor/SafeMath.sol"; | |||
There was a problem hiding this comment.
Include the OpenZeppelin library
contracts/Staking.sol
Outdated
| } | ||
|
|
||
| function totalStaked() public view returns (uint256) { | ||
| return totalStakedFor(msg.sender); |
There was a problem hiding this comment.
I think the totalStaked without parameter should return the TOTAL staked in the complete contract, according to the ERC900. So we may beed an attribute to store this and add or subtract when corresponds. I think its good to have that indicator in the contract directly.
* feat: add ERC20 mock contract move all tests related contracts to contract/test check if we get un-stake event * chore: fix linter
julianmrodri
requested review from
julianmrodri
and removed request for
vojtechsimetka
julianmrodri
approved these changes
Sep 2, 2020
* feat: add support of multi-currency for staking contract adjust tests * feat: fix pr comments * feat: add tests for native toke white list
|
Closed in favor of #132 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Solidity code and unit tests for a staking functionality in a separate contract.
I follows the guidelines from ERC900, but could not implement the interface to the letter, as it only worked with tokens and required some functions which we won't use.
The contract allows for staking in the token which is identified in the constructor (where address(0) is the native currency). Multi-currency is achieved by having multiple instances of this contract.
The contract only allows for unstaking when there is no capacity utilized from the StorageManager contract.