Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for building and running the TCPSigner bundle on arm64 #108

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

amendelzon
Copy link
Collaborator

  • Fixed middleware docker image build on arm64 platform (support for arm64 processors was added on version 4.4 of pyinstaller. Bumping the version to the latest (5.4.1) fixes mware docker image build. See the release notes for more info: https://pyinstaller.org/en/v5.0/CHANGES.html#id36).
  • Added documentation for building the TCPSigner bundle on arm64 platforms

italo-sampaio
italo-sampaio previously approved these changes Dec 23, 2022
Copy link
Collaborator

@italo-sampaio italo-sampaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amendelzon amendelzon force-pushed the enhancement/support-tcpsigner-bundle-arm64 branch from 0cf1e18 to a16f2b9 Compare December 23, 2022 14:03
…platform (#91)

- Fixed middleware docker image build on arm64 platform (support for arm64 processors was added on version 4.4 of pyinstaller. Bumping the version to the latest (5.4.1) fixes mware docker image build. See the release notes for more info: https://pyinstaller.org/en/v5.0/CHANGES.html#id36).
- Added documentation for building the TCPSigner bundle on arm64 platforms
@amendelzon amendelzon force-pushed the enhancement/support-tcpsigner-bundle-arm64 branch from a16f2b9 to 04ccecf Compare December 23, 2022 14:35
Copy link
Collaborator

@italo-sampaio italo-sampaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amendelzon amendelzon merged commit d9fd92b into master Dec 23, 2022
@amendelzon amendelzon deleted the enhancement/support-tcpsigner-bundle-arm64 branch December 23, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants