Implemented authorised segwit transaction signing #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
amendelzon
commented
Apr 3, 2024
amendelzon
commented
- Implemented signer changes to allow for both legacy and segwit sighash computation and signing
- Implemented new signing operation and changes in existing signing operations in middleware to support ledger changes
- Added ledger tests support for segwit signing tests
- Added new ledger test cases covering multiple segwit signing use cases
- Added new and updated existing middleware unit tests
- Updated protocol documentation to reflect new signing operation and changes in existing signing operations
- Implemented signer changes to allow for both legacy and segwit sighash computation and signing - Implemented new signing operation and changes in existing signing operations in middleware to support ledger changes - Added ledger tests support for segwit signing tests - Added new ledger test cases covering multiple segwit signing use cases - Added new and updated existing middleware unit tests - Updated protocol documentation to reflect new signing operation and changes in existing signing operations
amendelzon
force-pushed
the
feature/segwit-sighash
branch
from
b9f5ce4 to
e4aa4b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.