Improving remasc blocks retrieval; removing unused BlockStore method #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsebrie
previously approved these changes
Oct 28, 2019
| Block currentBlock = blockStore.getBlockByHashAndDepth( | ||
| executionBlock.getParentHash().getBytes(), | ||
| remascConstants.getMaturity() - 1 - uncleGenerationLimit | ||
| // this search is noe optimized if have certainty that the execution block is not in a fork |
There was a problem hiding this comment.
Is this change on the comment intended?
There was a problem hiding this comment.
Yes, the algorithm supports the existence of a fork, but it could be degraded to the original algorithm performance if the fork involves > blocks than the remasc maturity parameter
diegomasini
suggested changes
Nov 5, 2019
| Block currentBlock = blockStore.getBlockByHashAndDepth( | ||
| executionBlock.getParentHash().getBytes(), | ||
| remascConstants.getMaturity() - 1 - uncleGenerationLimit | ||
| // this search is noe optimized if have certainty that the execution block is not in a fork |
There was a problem hiding this comment.
Minor typo: noe should be replaced by not
|
LGTM! I only found a minor typo, @ajlopez please fix it and I will approve the PR. |
lsebrie
force-pushed
the
remascimprove
branch
from
4625478 to
08d3386
Compare
diegomasini
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remasc precompiled contract usually retrieved 4000 blocks in mainchain, each time. Now, the retrieve of the execution block (current block - maturity aprox) was replaced by an algorithm using in other uses cases. The old method used was removed.