-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Black weight is being used as the default weight of Inter #498
Comments
|
Very strange.
For me, with Chrome 106.0.5249.91 and the fonts in "Desktop" folder from the latest v4 beta works correctly:
For what font file? (you say you are using fonts in the "Desktop" folder, so which one of them did you open to get this screenshot?) With the latest v4 beta it looks fine on macOS 10.15 for me. Can you select the info tab for inter like this in Font Book and share a screenshot? |
Here's a video of the full installation and usage. It appears the last Chromium/Chrome/Canary do not load Wikipedia with an error in the font loading but Arc does so I'll report a bug to them also for the different behaving. But Affinity/Pixelmator still load Black Inter as the default Inter which is a bit weird. I tried loading Wikipedia pages on these 4 browsers and refreshing the cache but it didn't change anything, Arc still has the bug but other Chrom* still not suffer from this beside the settings page. Here's another example: bug.2.movThis is maybe a bug on macOS Ventura and 's software. Word seems to not suffer from it. |
Can you please show me exactly what font files you have installed? Either through font book as I requested earlier or via Finder. I want to make sure you have the static fonts in the "Desktop" folder installed and not the variable one. |
It seems, the video is too heavy but github provided this link: https://user-images.githubusercontent.com/42325924/193406024-9c5cf7eb-0772-4d7e-85c1-23050a31b7e3.mov |
Please, I just need to know EXACTLY what font files you have installed. I appreciate the effort with the videos, but it’s not effective (that last video doesn’t play on my iPhone.) |
Inter-4.00-3f174fcef6-Desktop.zip I'm doing my best, I said it was "Desktop" files, from the Inter 4 beta 1, from the zip available on the tags page of GitHub, so those files you built. This is the version the fontbook shows: I literally made a
Please tell me what evidence you're looking forward to. Anyway, just saw you released b2, I will try it. EDIT : Same behavior with beta2. |
Since I can't reproduce this myself in Chrome or on macOS, I must assume that there's something fishy going on (for example duplicate versions of Inter in your ~/Library/Fonts directory, sourcing the variable font.) As you seem comfortable with using a terminal/shell, try this:
And paste the output in a reply here. |
This is the result when I have the Inter font files installed from And this is the output after manual installation of the beta version:
@kenmcd This is completely what I suspected. |
Thank you, this is good information! |
Interesting. This smells like a regression in fontmake, which is invoked like this to create UFOs:
Here, fontmake produces the .designspace file AND the six master UFOs, including Inter-Black.ufo. Looking at Inter-Black.ufo/fontinfo.plist, it is missing a The designspace file is correct though:
|
Filed an issue with fontmake: googlefonts/fontmake#943 |
@kenmcd I'm curious what tool this is that has such a nice UI for style linking? Style liking is a complete mystery to me. |
Workaround for bug in fontmake which caused incorrect weight metadata in static fonts. See googlefonts/fontmake#943 Related to #498
@rsms This is TransType https://www.fontlab.com/font-converter/transtype/. Going to try it again. EDIT : It is working. |
Yes, it is TransType from FontLab. @aemi-dev I fixed the names and weights for 4 Beta 3. |
@kenmcd @rsms This is almost good. Now, it's Display Regular which is used as the default variant of Inter. @rsms Why didn't you keep Inter Display as a distinct font? It makes it far easier to use and it would prevent this sort of weird behaviors. It's only my opinion but Inter being my go-to font for almost everything, this little change will cause me a lot of trouble. |
Yeah, I was concerned about that. |
Nah @kenmcd you don't have to do that. It won't fix the fact Rasmus changed it. I mean, it's a problem for me, I don't know if it is for other people but at least he heard us on the different problems here. But thanks, I appreciate the work. I know the time it takes to do that x) |
@aemi-dev Already did it before I saw your response. |
I added a workaround for the fontmake bug in c797090. Here's a build:
It's primarily a variable font where "Display" is an opsz axis. Tooling makes it easy to produce static fonts with "Display" style but doesn't make it easy to produce static fonts where all "Display" styles becomes a separate family. Patches & suggestions welcome! Would probably be more ergonomic to have a separate family called "Inter Display". However, when the variable font is installed, all instances, including the Display styles, will be listed in most apps as separate styles. Here's what it looks like in Figma: Thank you both for helping out with this! |
@kenmcd Obviously it worked. Thanks @rsms It's a beta so I understand it is something I would have to wait for but it's definitely worth the work in term of usability (Apple iWorks suite does not offer the same UI as does Figma for example, nor Word and a lot of other). @rsms One who doesn't ask, doesn't get anything. You can still ask them. It would be a great gift/compensation for the work you've done on Inter, now used wiiiiidely. Can't get enough of the fact I discovered the version 2 of Inter years ago and now I see it everywhere. |
The weights are now good. |
To make the Bold and Italic buttons work as expected, some applications appear to connect the typographic family to the style group family via the expected RIBBI "normal" style group. So when these do not match applications can get confused. I cannot remember if it is Glyphs App or FontLab or ?? even has a "best practices" recommendation to make these match. I still do not fully understand how the GF, UFO/designspace, fonttools, etc. build process works. But I have seen other font families which are built separately. So I will keep an eye out on how it is done. |
Great. So the original mystery is solved. |
@kenmcd We're on the same page here.
I didn't remember the name of the tool at first, else I would have done the same thing you did for me. Anyway thank you. |
Maybe this one? The Glyphs educational content is so good. By renaming "Display Regular" to "Display" (and updating the linking, which I might not do properly?) we are getting closer. Display Bold Italic is not linked correctly though: |
Also it seems metrics keys were synced for Italic/uni0249
Here's a build with these changes: |
Yes the weight problem is fixed but now there's still the "problem" of both styles being labeled as Inter rather than Inter and Inter Display. Do you think you'll work on it for the v4 release ? |
I checked the 4.0-beta4 pre-release at all looks good now. See you got TransType. But TransType is GREAT for checking the style groups, for checking naming errors, for checking OS2 weight settings, for checking OS2 width settings, and for completely renaming entire font families. |
@rsms This issue will just get worse when you add some more instances for optical size, etc. |
I will try. I don't think fontmake makes this easy. Think I'll have to write a post processing script that edits metadata (and style linking) to get it done, which will have low prio for release 4.0 (there is TONS of other work to be done, all in my spare time.) Any ideas or contributions for making static-fonts only split into separate family names are welcome! |
In Glyphs, you would set the instances to not WWS-compatible, and supply WWS-compatible names like shown in the screenshot. That would present the fonts as separate families for apps that don't support mixing the normal with display styles. But this doesn't seem to be supported by fontmake, it doesn't write the WWS family and style names to name IDs 21 and 22. |
that's strange. I can see ufo2ft supports writing those if the UFO openTypeNameWWSFamilyName and openTypeNameWWSSubfamilyName font.info parameters: And I can see that glyphsLib seems to be exporting those (search "WWS" in this file https://github.com/googlefonts/glyphsLib/blob/main/Lib/glyphsLib/builder/custom_params.py). Please file an issue in either glyphsLib or ufo2ft or fontmake if in doubt, with a repro |
@jenskutilek I tried it (setting WWS names for all display instances) and indeed the OTFs produced by fontmake does not contain that information. The UFOs does not contain the WWS entries, but the .glyphs file does. I tried to make sense of |
Thank you @jenskutilek for filing this issue: googlefonts/glyphsLib#820 |
Patches UFO files to contain WWS entries. Also simplify UFO generation by moving the hard-coded make rules from the makefile into a shell script. Related to #498 and googlefonts/glyphsLib#820
I've added WWS entries for the Display styles of the static fonts. @aemi-dev can you try this new build and see if it works as expected? (I'm not sure how to test this myself beyond inspecting the font files and making sure they have seemingly-correct WWS entries) |
Any ideas how to make it default to "Regular" instead? |
I don't have any technical knowledge here but is it because for the same weight, style names are sorted alphabetically? |
@aemi-dev Do you have the variable fonts installed at the same time? You should not do that as the variable instance names can conflict with the static font names. The "V" variable fonts are named that way so they do not (should not) conflict. There are also issues with the variable instance names and master names. Tried to rename and test yesterday but FL8 did not play well with that glyphs package. I would almost get it all done and one of the masters would disappear. Was making me crazy(ier). Perhaps will try again tomorrow with FL7. |
Nah, I don't have the Variable font installed right now. And yea the V suffix should avoid this sort of problems. At least now I have a Display Regular as a default and it does not bother me that much. But yeah, that's still not it. |
@rsms I have installed the Inter v4 beta. But I cannot see the display fonts on Figma like how you get. Here's what I did:
I could see the Display fonts available in Pages and other apps. But not on Figma. |
@aravinddesign I have the "Inter V" fonts installed. Specifically:
(In Figma, make sure that in settings you disable "Google Fonts" to make sure Figma isn't listing the old Google release of Inter. Also if you are working in an organization version of Figma, make sure there's no Inter installed for the org as that would override your local fonts (terrible, I know.)) |
@rsms I've installed Inter V font and it works. Thank you! |
v4.0-beta6 includes the changes we've made so far |
I ... think we can close this issue? |
Describe the bug
The Inter default weight is the Black which is kind of problematic if you set Inter as the default font in your browser (assuming a Chromium based here) and reading through a site which use your default font.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The Regular version should be the default one.
Screenshots
bug.mp4
Environment
The text was updated successfully, but these errors were encountered: