Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Backup-Request / Retries. #102

Merged
merged 2 commits into from
Jun 23, 2016
Merged

Disable Backup-Request / Retries. #102

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed7033d
Disable Backup-Request / Retries.
stevegury Jun 23, 2016
98efa01
Address comments
stevegury Jun 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 1 addition & 34 deletions reactivesocket-client/src/main/java/io/reactivesocket/client/ClientBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,19 +103,6 @@ public ClientBuilder withConnectTimeout(long timeout, TimeUnit unit) {
);
}

public ClientBuilder withBackupRequest(double quantile) {
return new ClientBuilder(
name,
executor,
requestTimeout, requestTimeoutUnit,
connectTimeout, connectTimeoutUnit,
quantile,
retries, retryThisException,
connector,
source
);
}

public ClientBuilder withExecutor(ScheduledExecutorService executor) {
return new ClientBuilder(
name,
Expand Down Expand Up @@ -155,19 +142,6 @@ public ClientBuilder withSource(Publisher<List<SocketAddress>> source) {
);
}

public ClientBuilder withRetries(int nbOfRetries, Function<Throwable, Boolean> retryThisException) {
return new ClientBuilder(
name,
executor,
requestTimeout, requestTimeoutUnit,
connectTimeout, connectTimeoutUnit,
backupQuantile,
nbOfRetries, retryThisException,
connector,
source
);
}

public ReactiveSocket build() {
if (source == null) {
throw new IllegalStateException("Please configure the source!");
Expand All @@ -183,14 +157,7 @@ public ReactiveSocket build() {
Publisher<List<ReactiveSocketFactory<SocketAddress>>> factories =
sourceToFactory(source, filterConnector);

ReactiveSocket socket = new LoadBalancer(factories);
if (0.0 < backupQuantile && backupQuantile < 1.0) {
socket = new BackupRequestSocket(socket, backupQuantile, executor);
}
if (retries > 0) {
socket = new RetrySocket(socket, retries, t -> true);
}
return socket;
return new LoadBalancer(factories);
}

private Publisher<List<ReactiveSocketFactory<SocketAddress>>> sourceToFactory(
Expand Down