eliminate boxing in RequesterResponderSupport when using IntObjectMap #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
eliminate-boxing
branch
from
32332b9 to
0f93595
Compare
OlegDokuka
approved these changes
Nov 12, 2021
Comment on lines
122
to
128
| final IntObjectMap<FrameHandler> activeStreams = this.activeStreams; | ||
| // copy of Map.putIfAbsent(key, value) without `streamId` boxing | ||
| FrameHandler previousHandler = activeStreams.get(streamId); | ||
| if (previousHandler == null) { | ||
| previousHandler = activeStreams.put(streamId, frameHandler); | ||
| } | ||
| return previousHandler == null; |
There was a problem hiding this comment.
Suggested change
| final IntObjectMap<FrameHandler> activeStreams = this.activeStreams; | |
| // copy of Map.putIfAbsent(key, value) without `streamId` boxing | |
| FrameHandler previousHandler = activeStreams.get(streamId); | |
| if (previousHandler == null) { | |
| previousHandler = activeStreams.put(streamId, frameHandler); | |
| } | |
| return previousHandler == null; | |
| final IntObjectMap<FrameHandler> activeStreams = this.activeStreams; | |
| // copy of Map.putIfAbsent(key, value) without `streamId` boxing | |
| FrameHandler previousHandler = activeStreams.get(streamId); | |
| if (previousHandler == null) { | |
| activeStreams.put(streamId, frameHandler); | |
| return true; | |
| } | |
| return false; |
Signed-off-by: olme04 <[email protected]>
ghost
force-pushed
the
eliminate-boxing
branch
from
0f93595 to
e5818e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IntObjectMapimplementsMapand as so it has methods:default V putIfAbsent(K key, V value)default boolean remove(Object key, Object value)Those declarations uses
Objectfor keys, and not specified for usage ofintprimitive as key, and as so it autobox them.