Local Transport Improvements #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes general improvements to the Local Transport. It updates the code to make it better documented and tested. In addition it introduces the new TransportTest, a JUnit 5 way of testing uniformly across all of the transport implementations.
yschimke
approved these changes
Apr 17, 2018
| } | ||
|
|
||
| return UriHandler.super.buildServer(uri); | ||
| return Optional.of( | ||
| WebsocketServerTransport.create(uri.getHost(), WebsocketClientTransport.getPort(uri, 80))); |
There was a problem hiding this comment.
I believe this will cause a wss://rsocket.mycompany.com/endpoint to use 80 instead of 443
There was a problem hiding this comment.
That’s always been the case though. In this update, I’m aiming to not change any of the behavior as it exists. If we think it’s a bug, maybe opening an issue that I’ll work separately is the best way to go?
There was a problem hiding this comment.
Before it was only supporting plaintext as a server, so 80 was correct. IIRC my assumption at the time was it's easy to create a client with default SslContext etc, but servers generally require additional setup e.g. cert chains.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes general improvements to the Local Transport. It updates the code to make it better documented and tested. In addition it introduces the new
TransportTest, a JUnit 5 way of testing uniformly across all of the transport implementations.